Skip to content

Make Golang correctly delete temp files during uploading#36128

Merged
techknowlogick merged 1 commit into
go-gitea:mainfrom
wxiaoguang:fix-temp-file
Dec 11, 2025
Merged

Make Golang correctly delete temp files during uploading#36128
techknowlogick merged 1 commit into
go-gitea:mainfrom
wxiaoguang:fix-temp-file

Conversation

@wxiaoguang
Copy link
Copy Markdown
Contributor

@wxiaoguang wxiaoguang commented Dec 11, 2025

Fix #36127

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2025
@wxiaoguang wxiaoguang added backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.25 This PR should be backported to Gitea 1.25 type/bug labels Dec 11, 2025
@wxiaoguang wxiaoguang force-pushed the fix-temp-file branch 4 times, most recently from ba28bc7 to 2296af5 Compare December 11, 2025 09:39
@wxiaoguang wxiaoguang marked this pull request as draft December 11, 2025 09:40
@wxiaoguang wxiaoguang force-pushed the fix-temp-file branch 2 times, most recently from 80eb6b2 to 8c224e9 Compare December 11, 2025 11:46
@wxiaoguang wxiaoguang marked this pull request as ready for review December 11, 2025 11:50
@wxiaoguang wxiaoguang added this to the 1.26.0 milestone Dec 11, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2025
@techknowlogick techknowlogick merged commit f25409f into go-gitea:main Dec 11, 2025
23 checks passed
techknowlogick pushed a commit that referenced this pull request Dec 11, 2025
@wxiaoguang wxiaoguang deleted the fix-temp-file branch December 12, 2025 01:41
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 12, 2025
* giteaofficial/main:
  Move some functions to gitrepo package to reduce RepoPath reference directly (go-gitea#36126)
  Make Golang correctly delete temp files during uploading (go-gitea#36128)
  [skip ci] Updated translations via Crowdin
  Support updating branch via API (go-gitea#35951)
  Use gitrepo's clone and push when possible (go-gitea#36093)
  Improve math rendering (go-gitea#36124)
  Add matching pair insertion to markdown textarea (go-gitea#36121)
  Changed a small typo in an error message and code comments. (go-gitea#36117)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.25 This PR should be backported to Gitea 1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multipart-* temp files not be clean when call api: releases/id/assets

4 participants